sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fero Szabo via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69407: Refactor: break up Parameterized tests on a per database basis
Date Thu, 22 Nov 2018 13:40:27 GMT


> On Nov. 22, 2018, 8:29 a.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
> > Lines 24 (patched)
> > <https://reviews.apache.org/r/69407/diff/6/?file=2109532#file2109532line24>
> >
> >     Renamed files are shown as new files now which compromises the diff. Could you
please take a look and regenerate the diff?
> 
> Boglarka Egyed wrote:
>     Sorry, I wanted to say that it corrupts the diff.

Fixed with black-belt git magic, with the help of Szabi. ;)


- Fero


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69407/#review210785
-----------------------------------------------------------


On Nov. 22, 2018, 1:39 p.m., Fero Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69407/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2018, 1:39 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3405
>     https://issues.apache.org/jira/browse/SQOOP-3405
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Breaking up the parameterized test classes into a per database basis. Provides better
readability, needed for proper test categorization (and thus, for travis integration).
> 
> 
> Diffs
> -----
> 
>   src/test/org/apache/sqoop/importjob/DatabaseAdapterFactory.java PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/NumericTypesImportTest.java af310cbe2 
>   src/test/org/apache/sqoop/importjob/SplitByImportTest.java 90b7cbbd3 
>   src/test/org/apache/sqoop/importjob/configuration/MSSQLServerImportJobTestConfiguration.java
4ad7defe1 
>   src/test/org/apache/sqoop/importjob/configuration/MySQLImportJobTestConfiguration.java
fbcbdebeb 
>   src/test/org/apache/sqoop/importjob/numerictypes/MysqlNumericTypesImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/importjob/numerictypes/OracleNumericTypesImportTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/PostgresNumericTypesImportTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/numerictypes/SqlServerNumericTypesImportTest.java
PRE-CREATION 
>   src/test/org/apache/sqoop/importjob/splitby/MysqlSplitByImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/importjob/splitby/OracleSplitByImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/importjob/splitby/PostgresSplitByImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/importjob/splitby/SqlServerSplitByImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/testutil/adapter/MSSQLServerDatabaseAdapter.java 22567162d

>   src/test/org/apache/sqoop/testutil/adapter/MySqlDatabaseAdapter.java ebd014688 
> 
> 
> Diff: https://reviews.apache.org/r/69407/diff/7/
> 
> 
> Testing
> -------
> 
> unit and 3rd party tests.
> 
> 
> Thanks,
> 
> Fero Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message