sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Review Request 69434: SQOOP-3410: Test S3 import with fs.s3a.security.credential.provider.path
Date Thu, 22 Nov 2018 16:06:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69434/
-----------------------------------------------------------

Review request for Sqoop, Fero Szabo and Szabolcs Vasas.


Bugs: SQOOP-3410
    https://issues.apache.org/jira/browse/SQOOP-3410


Repository: sqoop-trunk


Description
-------

Based on https://hadoop.apache.org/docs/current/hadoop-aws/tools/hadoop-aws/index.html#Configure_the_hadoop.security.credential.provider.path_property
property fs.s3a.security.credential.provider.path can also be used for passing the location
of the credential store. This should be also tested and documented.


Diffs
-----

  src/docs/user/s3.txt 6ff828c497e0711a2394f768ed5d61ecaf9ec273 
  src/java/org/apache/sqoop/util/password/CredentialProviderHelper.java 4e79f0ae252969c4a426d1ff69072695eb37b7a6

  src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java dca3195b8051048c5c7c2fb3bf30774e9d19eda8

  src/test/org/apache/sqoop/s3/TestS3ImportWithHadoopCredProvider.java e1d7cbda2c65aa59a89715adff52b85fb3730477



Diff: https://reviews.apache.org/r/69434/diff/1/


Testing
-------

ant clean test
./gradlew -Ds3.bucket.url=<your-bucket-url> -Ds3.generator.command=<your-credential-generator-command>
s3Test --tests TestS3ImportWithHadoopCredProvider

ant clean docs
./gradlew docs


Thanks,

Boglarka Egyed


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message