sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 62523: SQOOP-3237: Mainframe FTP transfer option to insert custom FTP commands prior to transfer
Date Thu, 29 Nov 2018 11:46:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62523/
-----------------------------------------------------------

(Updated Nov. 29, 2018, 10:46 p.m.)


Review request for Sqoop.


Changes
-------

Changes based on feedback. Removed requirement to use --as-binaryfiles to use --ftp-commands


Bugs: SQOOP-3237
    https://issues.apache.org/jira/browse/SQOOP-3237


Repository: sqoop-trunk


Description
-------

Added --ftpcmds command to allow comma separated list of FTP commands to send.


Diffs (updated)
-----

  src/docs/user/import-mainframe.txt 3ecfb7e4 
  src/java/org/apache/sqoop/SqoopOptions.java f06872f9 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java 9842daa6 
  src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java 90dc2ddd 
  src/java/org/apache/sqoop/tool/MainframeImportTool.java fbc8c3db 
  src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java e7c48a6b 
  src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 502e6333

  src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 00e57bd0 
  src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java fc6e56d6 


Diff: https://reviews.apache.org/r/62523/diff/10/

Changes: https://reviews.apache.org/r/62523/diff/9-10/


Testing
-------

Unit tests.


File Attachments
----------------

SQOOP-3237-1.patch
  https://reviews.apache.org/media/uploaded/files/2017/09/26/56041556-e355-4372-83ab-1bcc01680201__SQOOP-3237-1.patch


Thanks,

Chris Teoh


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message