sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maugly24 <...@git.apache.org>
Subject [GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...
Date Thu, 29 Nov 2018 23:42:51 GMT
Github user maugly24 commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r237698979
  
    --- Diff: src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
---
    @@ -65,4 +66,21 @@
       public String toString() {
         return getClass().getSimpleName();
       }
    +
    +  @Override
    +  public Object[] getExpectedResultsForHive() {
    --- End diff --
    
    Source of code duplication again!
    I would move these expected values into a helper class or a super class (choice is up
to you).


---

Mime
View raw message