sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szvasas <...@git.apache.org>
Subject [GitHub] sqoop pull request #62: SQOOP-3415: Fixing gradle clean unittest and gradle ...
Date Fri, 30 Nov 2018 15:23:01 GMT
Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/62#discussion_r237896212
  
    --- Diff: build.gradle ---
    @@ -356,6 +359,15 @@ tasks.withType(Test) {
         ignoreFailures ignoreTestFailures
     }
     
    +project.tasks.each {
    +  if ( it.name.toLowerCase().endsWith('test') ) {
    +    it.doFirst({
    --- End diff --
    
    Could we move this piece of code to the tasks.withType(Test) block so we do not have to
iterate over the tasks:
    ```
    tasks.withType(Test) {
    ...
         doFirst {
               project.mkdir(testBuildDir)
               project.mkdir(testBuildDirData)
         }
    ...
    }
    ```


---

Mime
View raw message