sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import
Date Fri, 30 Nov 2018 21:51:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705314#comment-16705314
] 

ASF GitHub Bot commented on SQOOP-3396:
---------------------------------------

Github user maugly24 commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238013139
  
    --- Diff: src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
---
    @@ -65,4 +66,21 @@
       public String toString() {
         return getClass().getSimpleName();
       }
    +
    +  @Override
    +  public Object[] getExpectedResultsForHive() {
    --- End diff --
    
    Hi @fszabo2 ,
    
    If that's the case:
    Could you please at least add some information about the intention behind the values (A.K.A.
explanatory comments by Uncle Bob), b/c right now for example if this test would fail I would
not have much clue about what values do we have here, and why.
    
    I'm thinking about something like:
    this value is an int, XXX precision, so it should be YYYYY in Parquet/Hive
    
    or something like
    this value represents the biggest the longest possible values stored as type ZZZ, thus
it contains N digits, and should be KKKK in Hive.
    
    Could we add these information, thus put these "Magic numbers" into a context?


> Add parquet numeric support for Parquet in Hive import
> ------------------------------------------------------
>
>                 Key: SQOOP-3396
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3396
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Fero Szabo
>            Assignee: Fero Szabo
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message