sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3407) Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields
Date Wed, 21 Nov 2018 13:04:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694679#comment-16694679
] 

Hudson commented on SQOOP-3407:
-------------------------------

FAILURE: Integrated in Jenkins build Sqoop-hadoop200 #1229 (See [https://builds.apache.org/job/Sqoop-hadoop200/1229/])
SQOOP-3407 Introduce methods instead of TEMP_BASE_DIR and (fero: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=28896c8df1d151da29b3697c08fe5e81da4f3e94])
* (edit) src/test/org/apache/sqoop/TestMerge.java
* (edit) src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerImportTest.java
* (edit) src/test/org/apache/sqoop/orm/TestClassWriter.java
* (edit) src/test/org/apache/sqoop/testutil/BaseSqoopTestCase.java
* (edit) src/test/org/apache/sqoop/io/TestSplittableBufferedWriter.java
* (edit) src/test/org/apache/sqoop/credentials/TestPassingSecurePassword.java
* (edit) src/test/org/apache/sqoop/hbase/HBaseImportAddRowKeyTest.java
* (edit) src/test/org/apache/sqoop/TestIncrementalImport.java


> Introduce methods instead of TEMP_BASE_DIR and LOCAL_WAREHOUSE_DIR static fields
> --------------------------------------------------------------------------------
>
>                 Key: SQOOP-3407
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3407
>             Project: Sqoop
>          Issue Type: Test
>            Reporter: Szabolcs Vasas
>            Assignee: Szabolcs Vasas
>            Priority: Major
>         Attachments: SQOOP-3407.patch
>
>
> BaseSqoopTestCase.TEMP_BASE_DIR and BaseSqoopTestCase.LOCAL_WAREHOUSE_DIR are public
static fields which get initialized once at the JVM startup and store the paths for the
test temp and warehouse directories.
> The problem is that HBase test cases change the value of the test.build.data system property
which can cause tests using these static fields to fail.
> Since we do not own the code in HBase which changes the system property we need to turn
these static fields into methods which evaluate the test.build.data system property every
time they invoked which will make sure that the invoking tests will be successful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message