sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3415) Fix gradle test+build when clean applied as the first command + warning issue fixes
Date Fri, 30 Nov 2018 15:24:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704902#comment-16704902
] 

ASF GitHub Bot commented on SQOOP-3415:
---------------------------------------

Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/62#discussion_r237896212
  
    --- Diff: build.gradle ---
    @@ -356,6 +359,15 @@ tasks.withType(Test) {
         ignoreFailures ignoreTestFailures
     }
     
    +project.tasks.each {
    +  if ( it.name.toLowerCase().endsWith('test') ) {
    +    it.doFirst({
    --- End diff --
    
    Could we move this piece of code to the tasks.withType(Test) block so we do not have to
iterate over the tasks:
    ```
    tasks.withType(Test) {
    ...
         doFirst {
               project.mkdir(testBuildDir)
               project.mkdir(testBuildDirData)
         }
    ...
    }
    ```


> Fix gradle test+build when clean applied as the first command + warning issue fixes
> -----------------------------------------------------------------------------------
>
>                 Key: SQOOP-3415
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3415
>             Project: Sqoop
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: Attila Szabo
>            Assignee: Attila Szabo
>            Priority: Major
>             Fix For: 1.5.0
>
>
> If the user wants to build like the following command:
> gradlew clean unittest
> the gradle process ends up in an exception and the whole process left there hanging forever.
The root cause of this is the following:
> tasks.withType runs in the configuration part of the build, where we ensure the neccessary
directories exist.
> after that clean is executed and all of the dirs got deleted.
> Proposed fix:
> Apply directory creation as the first step of test tasks.
> on the top:
> there are some missing options b/c of Junit annotation processors, and also Xlint information
are swallowed currently. We aim to fix these things as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message