sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szvasas <...@git.apache.org>
Subject [GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...
Date Wed, 05 Dec 2018 09:27:52 GMT
Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238984033
  
    --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java ---
    @@ -41,30 +44,49 @@
     
       private final String hiveType;
       private final Schema schema;
    +  private final SqoopOptions options;
     
    -  @Parameters(name = "hiveType = {0}, schema = {1}")
    +  @Parameters(name = "hiveType = {0}, schema = {1}, options = {2}")
    --- End diff --
    
    I would not add options here, because SqoopOptions does not have a nice toString() method
so we won't see anything meaningful in the test output.


---

Mime
View raw message