sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From szvasas <...@git.apache.org>
Subject [GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...
Date Wed, 05 Dec 2018 09:27:52 GMT
Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238984411
  
    --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java ---
    @@ -41,30 +44,49 @@
     
       private final String hiveType;
       private final Schema schema;
    +  private final SqoopOptions options;
     
    -  @Parameters(name = "hiveType = {0}, schema = {1}")
    +  @Parameters(name = "hiveType = {0}, schema = {1}, options = {2}")
       public static Iterable<? extends Object> parameters() {
         return Arrays.asList(
    -        new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN)},
    -        new Object[]{"INT", Schema.create(Schema.Type.INT)},
    -        new Object[]{"BIGINT", Schema.create(Schema.Type.LONG)},
    -        new Object[]{"FLOAT", Schema.create(Schema.Type.FLOAT)},
    -        new Object[]{"DOUBLE", Schema.create(Schema.Type.DOUBLE)},
    -        new Object[]{"STRING", Schema.createEnum("ENUM", "doc", "namespce", new ArrayList<>())},
// Schema.Type.ENUM
    -        new Object[]{"STRING", Schema.create(Schema.Type.STRING)},
    -        new Object[]{"BINARY", Schema.create(Schema.Type.BYTES)},
    -        new Object[]{"BINARY", Schema.createFixed("Fixed", "doc", "space", 1) }
    -        //, new Object[]{"DECIMAL", Schema.create(Schema.Type.UNION).}
    +        new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN), new SqoopOptions()},
    +        new Object[]{"INT", Schema.create(Schema.Type.INT), new SqoopOptions()},
    +        new Object[]{"BIGINT", Schema.create(Schema.Type.LONG), new SqoopOptions()},
    +        new Object[]{"FLOAT", Schema.create(Schema.Type.FLOAT), new SqoopOptions()},
    +        new Object[]{"DOUBLE", Schema.create(Schema.Type.DOUBLE), new SqoopOptions()},
    +        new Object[]{"STRING", Schema.createEnum("ENUM", "doc", "namespce", new ArrayList<>()),
new SqoopOptions()}, // Schema.Type.ENUM
    --- End diff --
    
    Do we need the comment at the end of the line?


---

Mime
View raw message