sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import
Date Mon, 03 Dec 2018 16:26:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707474#comment-16707474
] 

ASF GitHub Bot commented on SQOOP-3396:
---------------------------------------

Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238332023
  
    --- Diff: src/test/org/apache/sqoop/importjob/numerictypes/NumericTypesParquetImportTestBase.java
---
    @@ -0,0 +1,89 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.sqoop.importjob.numerictypes;
    +
    +import org.apache.commons.logging.Log;
    +import org.apache.commons.logging.LogFactory;
    +import org.apache.hadoop.fs.Path;
    +import org.apache.parquet.schema.MessageType;
    +import org.apache.parquet.schema.OriginalType;
    +import org.apache.sqoop.importjob.configuration.ParquetTestConfiguration;
    +import org.apache.sqoop.testutil.ArgumentArrayBuilder;
    +import org.apache.sqoop.testutil.NumericTypesTestUtils;
    +import org.apache.sqoop.util.ParquetReader;
    +import org.junit.Before;
    +
    +import java.util.Arrays;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +public abstract class NumericTypesParquetImportTestBase<T extends ParquetTestConfiguration>
extends NumericTypesImportTestBase<T>  {
    +
    +  public static final Log LOG = LogFactory.getLog(NumericTypesParquetImportTestBase.class.getName());
    +
    +  public NumericTypesParquetImportTestBase(T configuration, boolean failWithoutExtraArgs,
boolean failWithPaddingOnly) {
    +    super(configuration, failWithoutExtraArgs, failWithPaddingOnly);
    +  }
    +
    +  @Before
    +  public void setUp() {
    +    super.setUp();
    +    tableDirPath = new Path(getWarehouseDir() + "/" + getTableName());
    --- End diff --
    
    tableDirPath seems to be initialized in super.setUp, do we need this here?


> Add parquet numeric support for Parquet in Hive import
> ------------------------------------------------------
>
>                 Key: SQOOP-3396
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3396
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Fero Szabo
>            Assignee: Fero Szabo
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message