sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3396) Add parquet numeric support for Parquet in Hive import
Date Wed, 05 Dec 2018 09:28:00 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16709821#comment-16709821
] 

ASF GitHub Bot commented on SQOOP-3396:
---------------------------------------

Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238984816
  
    --- Diff: src/test/org/apache/sqoop/hive/TestHiveTypesForAvroTypeMapping.java ---
    @@ -41,30 +44,49 @@
     
       private final String hiveType;
       private final Schema schema;
    +  private final SqoopOptions options;
     
    -  @Parameters(name = "hiveType = {0}, schema = {1}")
    +  @Parameters(name = "hiveType = {0}, schema = {1}, options = {2}")
       public static Iterable<? extends Object> parameters() {
         return Arrays.asList(
    -        new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN)},
    -        new Object[]{"INT", Schema.create(Schema.Type.INT)},
    -        new Object[]{"BIGINT", Schema.create(Schema.Type.LONG)},
    -        new Object[]{"FLOAT", Schema.create(Schema.Type.FLOAT)},
    -        new Object[]{"DOUBLE", Schema.create(Schema.Type.DOUBLE)},
    -        new Object[]{"STRING", Schema.createEnum("ENUM", "doc", "namespce", new ArrayList<>())},
// Schema.Type.ENUM
    -        new Object[]{"STRING", Schema.create(Schema.Type.STRING)},
    -        new Object[]{"BINARY", Schema.create(Schema.Type.BYTES)},
    -        new Object[]{"BINARY", Schema.createFixed("Fixed", "doc", "space", 1) }
    -        //, new Object[]{"DECIMAL", Schema.create(Schema.Type.UNION).}
    +        new Object[]{"BOOLEAN", Schema.create(Schema.Type.BOOLEAN), new SqoopOptions()},
    +        new Object[]{"INT", Schema.create(Schema.Type.INT), new SqoopOptions()},
    +        new Object[]{"BIGINT", Schema.create(Schema.Type.LONG), new SqoopOptions()},
    +        new Object[]{"FLOAT", Schema.create(Schema.Type.FLOAT), new SqoopOptions()},
    +        new Object[]{"DOUBLE", Schema.create(Schema.Type.DOUBLE), new SqoopOptions()},
    +        new Object[]{"STRING", Schema.createEnum("ENUM", "doc", "namespce", new ArrayList<>()),
new SqoopOptions()}, // Schema.Type.ENUM
    +        new Object[]{"STRING", Schema.create(Schema.Type.STRING), new SqoopOptions()},
    +        new Object[]{"BINARY", Schema.create(Schema.Type.BYTES), new SqoopOptions()},
    --- End diff --
    
    I would add one more test case here:
    new Object[]{"BINARY", create(Schema.Type.BYTES), createSqoopOptionsWithLogicalTypesEnabled()},
    
    to make sure that we test the if condition org/apache/sqoop/hive/HiveTypes.java:127 fully



> Add parquet numeric support for Parquet in Hive import
> ------------------------------------------------------
>
>                 Key: SQOOP-3396
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3396
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Fero Szabo
>            Assignee: Fero Szabo
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message