sqoop-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarek Jarcec Cecho <jar...@apache.org>
Subject Re: Question about submit patches
Date Fri, 25 Jul 2014 13:53:35 GMT
I usually request uploading patches to review board if they are bigger then just few lines.
In your case the patch have only 3 lines, so it was easy to review it even without review
board.

I’ve +1 and committed the patch - thank you for your contribution Guodong!

Jarcec

On Jul 24, 2014, at 10:29 PM, 王国栋 <wanggd04@gmail.com> wrote:

> Hi Jarek,
> 
> Thanks for your reply. I pulled the latest code in trunk, and now, the build succeeds.
> 
> I am going to format a patch soon.
> 
> Shall we upload the patch to any review board or just attach it in the jira? What is
the practice in sqoop community ?
> 
> Thanks.
> 
> Guodong
> 
> 
> On Fri, Jul 25, 2014 at 10:58 AM, Jarek Jarcec Cecho <jarcec@apache.org> wrote:
> Hi Guodong,
> I’m glad to hear your interest in contributing to Sqoop! You should definitely submit
patch that is build against trunk branch.
> 
> I’ve run the same command and it worked for me. Could you just try “ant clean test”
without any other parameters?
> 
> Jarcec
> 
> On Jul 24, 2014, at 7:39 PM, 王国栋 <wanggd04@gmail.com> wrote:
> 
> > Hi guys,
> >
> > I have a patch for this issue https://issues.apache.org/jira/browse/SQOOP-1368.
> >
> > But I don't know which branch i should use to test my patch before submitting to
code review.
> >
> > Currently, I have tested the patch in branch-1.4.2.  But when I tried to apply the
patch to trunk, I met some building issues. Looks like the ivy setting is not right. But I
am not good at ivy, please help.
> >
> > I used this command to build
> > ant clean jar  -Divy.version=2.2.0   -Dhadoopversion=200
> >
> > The following error message is like this
> >
> > [ivy:resolve]         org.apache.zookeeper#zookeeper;3.4.2 by [org.apache.zookeeper#zookeeper;3.4.3]
in [hadoop200]
> >       ---------------------------------------------------------------------
> >       |                  |            modules            ||   artifacts   |
> >       |       conf       | number| search|dwnlded|evicted|| number|dwnlded|
> >       ---------------------------------------------------------------------
> >       |     hadoop200    |  151  |   55  |   0   |   26  ||  125  |   0   |
> >       ---------------------------------------------------------------------
> > [ivy:resolve]
> > [ivy:resolve] :: problems summary ::
> > [ivy:resolve] :::: WARNINGS
> > [ivy:resolve]                 ::::::::::::::::::::::::::::::::::::::::::::::
> > [ivy:resolve]                 ::          UNRESOLVED DEPENDENCIES         ::
> > [ivy:resolve]                 ::::::::::::::::::::::::::::::::::::::::::::::
> > [ivy:resolve]                 :: org.apache.hive#hive-serde;0.11.0: configuration
not public in org.apache.hive#hive-serde;0.11.0: 'compile'. It was required from org.apache.hive#hive-metastore;0.11.0
compile
> > [ivy:resolve]                 :: org.apache.hive#hive-shims;0.11.0: configuration
not public in org.apache.hive#hive-shims;0.11.0: 'compile'. It was required from org.apache.hive#hive-cli;0.11.0
compile
> > [ivy:resolve]                 :: org.apache.hive#hive-common;0.11.0: configuration
not public in org.apache.hive#hive-common;0.11.0: 'compile'. It was required from org.apache.hcatalog#hcatalog-core;0.11.0
compile
> > [ivy:resolve]                 ::::::::::::::::::::::::::::::::::::::::::::::
> > [ivy:resolve]
> > [ivy:resolve] :: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE DETAILS
> >
> > BUILD FAILED
> >
> > Guodong
> 
> 


Mime
View raw message