storm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ptgo...@apache.org
Subject [09/24] git commit: throw RuntimeException and remove unnecessary System/exit
Date Tue, 19 Nov 2013 15:26:46 GMT
throw RuntimeException and remove unnecessary System/exit


Project: http://git-wip-us.apache.org/repos/asf/incubator-storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-storm/commit/7fa44bf1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-storm/tree/7fa44bf1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-storm/diff/7fa44bf1

Branch: refs/heads/master
Commit: 7fa44bf1f47579a9dccee0914e5decd1c1beed95
Parents: cbb1363
Author: Homer Strong <homer.strong@gmail.com>
Authored: Thu Oct 17 09:39:08 2013 -0700
Committer: Homer Strong <homer.strong@gmail.com>
Committed: Thu Oct 17 09:39:08 2013 -0700

----------------------------------------------------------------------
 storm-core/src/clj/backtype/storm/daemon/logviewer.clj | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-storm/blob/7fa44bf1/storm-core/src/clj/backtype/storm/daemon/logviewer.clj
----------------------------------------------------------------------
diff --git a/storm-core/src/clj/backtype/storm/daemon/logviewer.clj b/storm-core/src/clj/backtype/storm/daemon/logviewer.clj
index 92ef556..beec4a9 100644
--- a/storm-core/src/clj/backtype/storm/daemon/logviewer.clj
+++ b/storm-core/src/clj/backtype/storm/daemon/logviewer.clj
@@ -38,10 +38,8 @@ Note that if anything goes wrong, this will throw an Error and exit."
   (let [appender (.getAppender (LoggerFactory/getLogger Logger/ROOT_LOGGER_NAME) appender-name)]
     (if (and appender-name appender (instance? FileAppender appender))
       (.getParent (File. (.getFile appender)))
-      (do
-        (throw
-         (Error. "Log viewer could not find configured appender, or the appender is not a
FileAppender. Please check that the appender name configured in storm.yaml and cluster.xml
agree."))
-        (System/exit 1)))))
+      (throw
+       (RuntimeException. "Log viewer could not find configured appender, or the appender
is not a FileAppender. Please check that the appender name configured in storm and logback
agree.")))))
 
 (defn log-page [file tail grep root-dir]
   (let [path (.getCanonicalPath (File. root-dir file))


Mime
View raw message