storm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bo...@apache.org
Subject [38/50] git commit: Nodejs fail should not be followed by ack
Date Wed, 24 Sep 2014 17:57:05 GMT
Nodejs fail should not be followed by ack


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/e96b4467
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/e96b4467
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/e96b4467

Branch: refs/heads/security
Commit: e96b4467bedd5db7dfdcce9e5623da79ae2e5468
Parents: 2921336
Author: Itai Frenkel <itai@ryzyco.com>
Authored: Tue Sep 16 13:03:49 2014 +0300
Committer: Itai Frenkel <itai@ryzyco.com>
Committed: Tue Sep 16 13:03:49 2014 +0300

----------------------------------------------------------------------
 examples/storm-starter/multilang/resources/storm.js | 1 +
 storm-core/src/dev/resources/storm.js               | 1 +
 2 files changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/e96b4467/examples/storm-starter/multilang/resources/storm.js
----------------------------------------------------------------------
diff --git a/examples/storm-starter/multilang/resources/storm.js b/examples/storm-starter/multilang/resources/storm.js
index 4eef781..5c78072 100755
--- a/examples/storm-starter/multilang/resources/storm.js
+++ b/examples/storm-starter/multilang/resources/storm.js
@@ -246,6 +246,7 @@ BasicBolt.prototype.handleNewCommand = function(command) {
     var callback = function(err) {
           if (err) {
               self.fail(tup, err);
+              return;
           }
           self.ack(tup);
       }

http://git-wip-us.apache.org/repos/asf/storm/blob/e96b4467/storm-core/src/dev/resources/storm.js
----------------------------------------------------------------------
diff --git a/storm-core/src/dev/resources/storm.js b/storm-core/src/dev/resources/storm.js
index 4eef781..5c78072 100755
--- a/storm-core/src/dev/resources/storm.js
+++ b/storm-core/src/dev/resources/storm.js
@@ -246,6 +246,7 @@ BasicBolt.prototype.handleNewCommand = function(command) {
     var callback = function(err) {
           if (err) {
               self.fail(tup, err);
+              return;
           }
           self.ack(tup);
       }


Mime
View raw message