storm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kabh...@apache.org
Subject [1/2] storm git commit: STORM-841 Thread-safeness of OutputCollector has documented contrary to two official doc.
Date Fri, 12 Aug 2016 02:19:54 GMT
Repository: storm
Updated Branches:
  refs/heads/0.9.x-branch e9cffeee8 -> d9f188117


STORM-841 Thread-safeness of OutputCollector has documented contrary to two official doc.

* Fix for 0.10.x


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/c33a58b2
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/c33a58b2
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/c33a58b2

Branch: refs/heads/0.9.x-branch
Commit: c33a58b2042cd50cd2ddc1cf155f70d7c617ac8e
Parents: e9cffee
Author: Jungtaek Lim <kabhwan@gmail.com>
Authored: Fri Aug 12 08:41:22 2016 +0900
Committer: Jungtaek Lim <kabhwan@gmail.com>
Committed: Fri Aug 12 11:19:30 2016 +0900

----------------------------------------------------------------------
 docs/Concepts.md | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/c33a58b2/docs/Concepts.md
----------------------------------------------------------------------
diff --git a/docs/Concepts.md b/docs/Concepts.md
index 33779f2..baaeaf4 100644
--- a/docs/Concepts.md
+++ b/docs/Concepts.md
@@ -65,7 +65,8 @@ When you declare a bolt's input streams, you always subscribe to specific
stream
 
 The main method in bolts is the `execute` method which takes in as input a new tuple. Bolts
emit new tuples using the [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html)
object. Bolts must call the `ack` method on the `OutputCollector` for every tuple they process
so that Storm knows when tuples are completed (and can eventually determine that its safe
to ack the original spout tuples). For the common case of processing an input tuple, emitting
0 or more tuples based on that tuple, and then acking the input tuple, Storm provides an [IBasicBolt](javadocs/backtype/storm/topology/IBasicBolt.html)
interface which does the acking automatically.
 
-Its perfectly fine to launch new threads in bolts that do processing asynchronously. [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html)
is thread-safe and can be called at any time.
+Please note that [OutputCollector](javadocs/backtype/storm/task/OutputCollector.html) is
not thread-safe, and all emits, acks, and fails must happen on the same thread. Please refer
[Troubleshooting](troubleshooting.html) for more details.
+
 
 **Resources:**
 


Mime
View raw message