storm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bo...@apache.org
Subject [1/3] storm git commit: STORM-2212: Remove Redundant Declarations in Maven POM Files - Remove redundant declarations cause warnings and make the build files harder to extend and maintain
Date Wed, 23 Nov 2016 20:09:23 GMT
Repository: storm
Updated Branches:
  refs/heads/master 10c85726a -> ecb3fd896


STORM-2212: Remove Redundant Declarations in Maven POM Files
  - Remove redundant declarations cause warnings and make the build files harder to extend
and maintain


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/ccd51076
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/ccd51076
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/ccd51076

Branch: refs/heads/master
Commit: ccd5107649bb289e18a51b0ce1ceab4b70b82dd0
Parents: ea67694
Author: Hugo Louro <hmclouro@gmail.com>
Authored: Mon Nov 21 17:07:04 2016 -0800
Committer: Hugo Louro <hmclouro@gmail.com>
Committed: Tue Nov 22 08:37:16 2016 -0800

----------------------------------------------------------------------
 examples/storm-starter/pom.xml                          |  1 +
 external/flux/pom.xml                                   |  6 ------
 external/storm-cassandra/pom.xml                        |  7 -------
 external/storm-eventhubs/pom.xml                        |  6 ------
 external/storm-hdfs/pom.xml                             |  6 ------
 external/storm-hive/pom.xml                             |  6 ------
 external/storm-jdbc/pom.xml                             |  6 ------
 external/storm-jms/examples/pom.xml                     |  1 -
 external/storm-jms/pom.xml                              | 12 ------------
 external/storm-kafka-client/pom.xml                     |  6 ------
 external/storm-kafka/pom.xml                            |  6 ------
 external/storm-metrics/pom.xml                          |  1 -
 external/storm-solr/pom.xml                             |  6 ------
 .../maven-shade-clojure-transformer/pom.xml             |  1 -
 storm-buildtools/storm-maven-plugins/pom.xml            |  2 +-
 storm-core/pom.xml                                      |  2 +-
 storm-dist/binary/pom.xml                               |  2 +-
 storm-dist/source/pom.xml                               |  2 +-
 storm-multilang/javascript/pom.xml                      |  2 +-
 storm-multilang/python/pom.xml                          |  2 +-
 storm-multilang/ruby/pom.xml                            |  2 +-
 storm-rename-hack/pom.xml                               |  3 +--
 22 files changed, 9 insertions(+), 79 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/examples/storm-starter/pom.xml
----------------------------------------------------------------------
diff --git a/examples/storm-starter/pom.xml b/examples/storm-starter/pom.xml
index df443de..36cf83c 100644
--- a/examples/storm-starter/pom.xml
+++ b/examples/storm-starter/pom.xml
@@ -237,6 +237,7 @@
           <includeProjectDependencies>true</includeProjectDependencies>
           <includePluginDependencies>false</includePluginDependencies>
           <classpathScope>compile</classpathScope>
+          <!-- allows you to specify which topology class to run by specifying -Dstorm.topology=
on the command line -->
           <mainClass>${storm.topology}</mainClass>
         </configuration>
       </plugin>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/flux/pom.xml
----------------------------------------------------------------------
diff --git a/external/flux/pom.xml b/external/flux/pom.xml
index a795df7..b51a505 100644
--- a/external/flux/pom.xml
+++ b/external/flux/pom.xml
@@ -81,11 +81,5 @@
             <artifactId>${storm.kafka.artifact.id}</artifactId>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 </project>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-cassandra/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-cassandra/pom.xml b/external/storm-cassandra/pom.xml
index c64d71d..e0f41d8 100644
--- a/external/storm-cassandra/pom.xml
+++ b/external/storm-cassandra/pom.xml
@@ -95,13 +95,6 @@
         </dependency>
 
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>${junit.version}</version>
-            <scope>test</scope>
-        </dependency>
-
-        <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-all</artifactId>
             <version>1.10.19</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-eventhubs/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-eventhubs/pom.xml b/external/storm-eventhubs/pom.xml
index 452c971..7a54790 100755
--- a/external/storm-eventhubs/pom.xml
+++ b/external/storm-eventhubs/pom.xml
@@ -114,11 +114,5 @@
             <artifactId>qpid-amqp-1-0-common</artifactId>
             <version>${qpid.version}</version>
         </dependency>
-        <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 </project>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-hdfs/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-hdfs/pom.xml b/external/storm-hdfs/pom.xml
index db4a34f..aba0da6 100644
--- a/external/storm-hdfs/pom.xml
+++ b/external/storm-hdfs/pom.xml
@@ -182,12 +182,6 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-minicluster</artifactId>
             <version>${hadoop.version}</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-hive/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-hive/pom.xml b/external/storm-hive/pom.xml
index 5c7d900..a564e85 100644
--- a/external/storm-hive/pom.xml
+++ b/external/storm-hive/pom.xml
@@ -136,12 +136,6 @@
       </exclusions>
     </dependency>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
-      <version>4.11</version>
-      <scope>test</scope>
-    </dependency>
-    <dependency>
       <groupId>org.mockito</groupId>
       <artifactId>mockito-all</artifactId>
       <version>1.9.0</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-jdbc/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-jdbc/pom.xml b/external/storm-jdbc/pom.xml
index 68b8bcb..a8c3de0 100644
--- a/external/storm-jdbc/pom.xml
+++ b/external/storm-jdbc/pom.xml
@@ -63,12 +63,6 @@
             <scope>compile</scope>
         </dependency>
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>org.hsqldb</groupId>
             <artifactId>hsqldb</artifactId>
             <version>2.3.1</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-jms/examples/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-jms/examples/pom.xml b/external/storm-jms/examples/pom.xml
index cb78f02..b099b88 100644
--- a/external/storm-jms/examples/pom.xml
+++ b/external/storm-jms/examples/pom.xml
@@ -98,7 +98,6 @@
                     </descriptorRefs>
                     <archive>
                         <manifest>
-                            <mainClass></mainClass>
                         </manifest>
                     </archive>
                 </configuration>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-jms/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-jms/pom.xml b/external/storm-jms/pom.xml
index 0881939..6a6e60a 100644
--- a/external/storm-jms/pom.xml
+++ b/external/storm-jms/pom.xml
@@ -43,18 +43,6 @@
         <module>examples</module>
     </modules>
 
-    <dependencies>
-        <dependency>
-            <groupId>org.apache.storm</groupId>
-            <artifactId>storm-core</artifactId>
-            <version>${project.version}</version>
-            <!-- keep storm out of the jar-with-dependencies -->
-            <scope>provided</scope>
-        </dependency>
-
-    </dependencies>
-
-
     <build>
         <plugins>
             <plugin>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-kafka-client/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-kafka-client/pom.xml b/external/storm-kafka-client/pom.xml
index 2d9a844..a7971e2 100644
--- a/external/storm-kafka-client/pom.xml
+++ b/external/storm-kafka-client/pom.xml
@@ -75,12 +75,6 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>info.batey.kafka</groupId>
             <artifactId>kafka-unit</artifactId>
             <version>0.6</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-kafka/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-kafka/pom.xml b/external/storm-kafka/pom.xml
index 08550c3..9c69c05 100644
--- a/external/storm-kafka/pom.xml
+++ b/external/storm-kafka/pom.xml
@@ -69,12 +69,6 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>org.apache.curator</groupId>
             <artifactId>curator-framework</artifactId>
             <version>${curator.version}</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-metrics/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-metrics/pom.xml b/external/storm-metrics/pom.xml
index dfe9699..24b34e8 100644
--- a/external/storm-metrics/pom.xml
+++ b/external/storm-metrics/pom.xml
@@ -24,7 +24,6 @@
       <relativePath>../../pom.xml</relativePath>
   </parent>
 
-  <groupId>org.apache.storm</groupId>
   <artifactId>storm-metrics</artifactId>
   <packaging>jar</packaging>
 

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/external/storm-solr/pom.xml
----------------------------------------------------------------------
diff --git a/external/storm-solr/pom.xml b/external/storm-solr/pom.xml
index ba79ddc..a7cc287 100644
--- a/external/storm-solr/pom.xml
+++ b/external/storm-solr/pom.xml
@@ -85,12 +85,6 @@
         </dependency>
         <!--test dependencies -->
         <dependency>
-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <version>4.11</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
             <version>2.3.1</version>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-buildtools/maven-shade-clojure-transformer/pom.xml
----------------------------------------------------------------------
diff --git a/storm-buildtools/maven-shade-clojure-transformer/pom.xml b/storm-buildtools/maven-shade-clojure-transformer/pom.xml
index d58c614..be5c02f 100644
--- a/storm-buildtools/maven-shade-clojure-transformer/pom.xml
+++ b/storm-buildtools/maven-shade-clojure-transformer/pom.xml
@@ -25,7 +25,6 @@
         <relativePath>../../pom.xml</relativePath>
     </parent>
 
-    <groupId>org.apache.storm</groupId>
     <artifactId>maven-shade-clojure-transformer</artifactId>
 
     <dependencies>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-buildtools/storm-maven-plugins/pom.xml
----------------------------------------------------------------------
diff --git a/storm-buildtools/storm-maven-plugins/pom.xml b/storm-buildtools/storm-maven-plugins/pom.xml
index 2330db3..3945d46 100644
--- a/storm-buildtools/storm-maven-plugins/pom.xml
+++ b/storm-buildtools/storm-maven-plugins/pom.xml
@@ -25,7 +25,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
   </parent>
-  <groupId>org.apache.storm</groupId>
+
   <artifactId>storm-maven-plugins</artifactId>
   <packaging>maven-plugin</packaging>
   <name>storm-maven-plugins</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-core/pom.xml
----------------------------------------------------------------------
diff --git a/storm-core/pom.xml b/storm-core/pom.xml
index f09126c..b6424d7 100644
--- a/storm-core/pom.xml
+++ b/storm-core/pom.xml
@@ -23,7 +23,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>..</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>storm-core</artifactId>
     <packaging>jar</packaging>
     <name>Storm Core</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-dist/binary/pom.xml
----------------------------------------------------------------------
diff --git a/storm-dist/binary/pom.xml b/storm-dist/binary/pom.xml
index f7d0c23..d544ff0 100644
--- a/storm-dist/binary/pom.xml
+++ b/storm-dist/binary/pom.xml
@@ -24,7 +24,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>apache-storm-bin</artifactId>
     <packaging>pom</packaging>
     <name>Storm Binary Distribution</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-dist/source/pom.xml
----------------------------------------------------------------------
diff --git a/storm-dist/source/pom.xml b/storm-dist/source/pom.xml
index 0907e5c..79d8a93 100644
--- a/storm-dist/source/pom.xml
+++ b/storm-dist/source/pom.xml
@@ -24,7 +24,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>apache-storm-source</artifactId>
     <packaging>pom</packaging>
     <name>Storm Source Distribution</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-multilang/javascript/pom.xml
----------------------------------------------------------------------
diff --git a/storm-multilang/javascript/pom.xml b/storm-multilang/javascript/pom.xml
index 85ffbca..dad0854 100644
--- a/storm-multilang/javascript/pom.xml
+++ b/storm-multilang/javascript/pom.xml
@@ -25,7 +25,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>multilang-javascript</artifactId>
     <packaging>jar</packaging>
     <name>multilang-javascript</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-multilang/python/pom.xml
----------------------------------------------------------------------
diff --git a/storm-multilang/python/pom.xml b/storm-multilang/python/pom.xml
index c59aa2d..d4a2bd4 100644
--- a/storm-multilang/python/pom.xml
+++ b/storm-multilang/python/pom.xml
@@ -24,7 +24,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>multilang-python</artifactId>
     <packaging>jar</packaging>
     <name>multilang-python</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-multilang/ruby/pom.xml
----------------------------------------------------------------------
diff --git a/storm-multilang/ruby/pom.xml b/storm-multilang/ruby/pom.xml
index 510b44c..f0cffd2 100644
--- a/storm-multilang/ruby/pom.xml
+++ b/storm-multilang/ruby/pom.xml
@@ -24,7 +24,7 @@
         <version>2.0.0-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
-    <groupId>org.apache.storm</groupId>
+
     <artifactId>multilang-ruby</artifactId>
     <packaging>jar</packaging>
     <name>multilang-ruby</name>

http://git-wip-us.apache.org/repos/asf/storm/blob/ccd51076/storm-rename-hack/pom.xml
----------------------------------------------------------------------
diff --git a/storm-rename-hack/pom.xml b/storm-rename-hack/pom.xml
index def5098..7af65ea 100644
--- a/storm-rename-hack/pom.xml
+++ b/storm-rename-hack/pom.xml
@@ -24,10 +24,9 @@
     <relativePath>../pom.xml</relativePath>
   </parent>
 
-  <groupId>org.apache.storm</groupId>
+
   <artifactId>storm-rename-hack</artifactId>
   <packaging>jar</packaging>
-
   <name>storm-rename-hack</name>
 
   <properties>


Mime
View raw message