storm-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bo...@apache.org
Subject [3/7] storm git commit: [STORM-2510] update line-length limit to 140 from 120 (originally 100), and add the Apache License boilerplate to the storm_checkstyle.xml file
Date Mon, 15 May 2017 15:09:50 GMT
[STORM-2510] update line-length limit to 140 from 120 (originally 100), and add the Apache
License boilerplate to the storm_checkstyle.xml file


Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/772c334c
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/772c334c
Diff: http://git-wip-us.apache.org/repos/asf/storm/diff/772c334c

Branch: refs/heads/master
Commit: 772c334caee061eb7b90803045a2cea5d3ff1021
Parents: 29c7619
Author: Erik Weathers <erikdw@gmail.com>
Authored: Fri May 12 10:12:08 2017 -0700
Committer: Erik Weathers <erikdw@gmail.com>
Committed: Fri May 12 10:12:08 2017 -0700

----------------------------------------------------------------------
 storm-buildtools/storm_checkstyle.xml | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/storm/blob/772c334c/storm-buildtools/storm_checkstyle.xml
----------------------------------------------------------------------
diff --git a/storm-buildtools/storm_checkstyle.xml b/storm-buildtools/storm_checkstyle.xml
index d82a0a7..248e3ce 100644
--- a/storm-buildtools/storm_checkstyle.xml
+++ b/storm-buildtools/storm_checkstyle.xml
@@ -1,4 +1,22 @@
 <?xml version="1.0"?>
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+     http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
 <!DOCTYPE module PUBLIC
           "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
           "http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
@@ -8,7 +26,7 @@
       https://raw.githubusercontent.com/checkstyle/checkstyle/checkstyle-7.7/src/main/resources/google_checks.xml
     It has been slightly modified for use in Apache Storm, as follows:
       * 4 space indents instead of 2
-      * line-length limit is 120 instead of 100
+      * line-length limit is 140 instead of 100
     Once checkstyle has the ability to override selected configuration elements from within
the Maven
     pom.xml file, then we can remove this file in favor of overriding the provided google_checks.xml
file.
     See this issue to track that functionality:
@@ -52,7 +70,7 @@
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
         <module name="LineLength">
-            <property name="max" value="120"/>
+            <property name="max" value="140"/>
             <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
         </module>
         <module name="AvoidStarImport"/>
@@ -64,7 +82,7 @@
         </module>
         <module name="NeedBraces"/>
         <module name="LeftCurly">
-            <property name="maxLineLength" value="120"/>
+            <property name="maxLineLength" value="140"/>
         </module>
         <module name="RightCurly">
             <property name="id" value="RightCurlySame"/>


Mime
View raw message