storm-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kobi Salant <ko...@liveperson.com>
Subject Re: AOP in Storm
Date Mon, 02 Feb 2015 08:08:16 GMT
Thank Brian again,

Do you think there are any performance issues regarding the Aspect
framework itself? I am not talking about the code itself that of course
will have an overhead.

Thanks
Kobi

On Sun, Feb 1, 2015 at 2:42 PM, Brian O'Neill <bone@alumni.brown.edu> wrote:

> We use aspectj and create point cuts:
>
>     /**
>      * Common Reactor Pointcuts
>      * http://blog.espenberntsen.net/2010/03/20/aspectj-cheat-sheet/
>      */
>     @Pointcut("execution(* execute(..))")
>     public void execute() {}
>
>     @Pointcut("execution(* updateState(..))")
>     public void updateState() {}
>
>     @Pointcut("execution(* *..EntityJdbiState.commit(..))")
>     public void commit() {}
>
> Things get woven into the jar via aspectj-maven-plugin.
>
> For state object, the updateState and commit point cuts above would get
> triggered.
>
> We then use the point cut to log execution times, e.g.:
>
>  protected Object logExecution(ProceedingJoinPoint pjp) throws Throwable {
>
>
> -brian
>
> ---
>
> *Brian O'Neill *
>
> Chief Technology Officer
>
> Health Market Science, a LexisNexis Company
>
> 215.588.6024 Mobile • @boneill42 <http://www.twitter.com/boneill42>
>
>
> This information transmitted in this email message is for the intended
> recipient only and may contain confidential and/or privileged material. If
> you received this email in error and are not the intended recipient, or the
> person responsible to deliver it to the intended recipient, please contact
> the sender at the email above and delete this email and any attachments and
> destroy any copies thereof. Any review, retransmission, dissemination,
> copying or other use of, or taking any action in reliance upon, this
> information by persons or entities other than the intended recipient is
> strictly prohibited.
>
>
>
>
> From: Kobi Salant <kobis@liveperson.com>
> Reply-To: <user@storm.apache.org>
> Date: Sunday, February 1, 2015 at 7:29 AM
> To: <user@storm.apache.org>
> Subject: Re: AOP in Storm
>
> Thanks Brian,
>
> If it is not too much to ask, can you give me a brief description how you
> instrument it and access the satets.
>
> Kobi
>
> On Sun, Feb 1, 2015 at 2:22 PM, Brian O'Neill <bone@alumni.brown.edu>
> wrote:
>
>> Yes, we use AOP to get metrics/timings for individual functions/states
>> within Storm.
>> It works like a charm.
>>
>> If you’d like, we could potentially open source that code.
>>
>> -brian
>>
>> ---
>>
>> *Brian O'Neill *
>>
>> Chief Technology Officer
>>
>> Health Market Science, a LexisNexis Company
>>
>> 215.588.6024 Mobile • @boneill42 <http://www.twitter.com/boneill42>
>>
>>
>> This information transmitted in this email message is for the intended
>> recipient only and may contain confidential and/or privileged material. If
>> you received this email in error and are not the intended recipient, or the
>> person responsible to deliver it to the intended recipient, please contact
>> the sender at the email above and delete this email and any attachments and
>> destroy any copies thereof. Any review, retransmission, dissemination,
>> copying or other use of, or taking any action in reliance upon, this
>> information by persons or entities other than the intended recipient is
>> strictly prohibited.
>>
>>
>>
>>
>> From: Kobi Salant <kobis@liveperson.com>
>> Reply-To: <user@storm.apache.org>
>> Date: Sunday, February 1, 2015 at 2:28 AM
>> To: <user@storm.apache.org>
>> Subject: AOP in Storm
>>
>> Hi,
>>
>> Did anyone add any experience in adding "Aspect" to Storm?
>> Is there any reason not to do it?
>>
>> Thanks
>> Kobi
>>
>> This message may contain confidential and/or privileged information.
>> If you are not the addressee or authorized to receive this on behalf of
>> the addressee you must not use, copy, disclose or take action based on this
>> message or any information herein.
>> If you have received this message in error, please advise the sender
>> immediately by reply email and delete this message. Thank you.
>>
>
>
> This message may contain confidential and/or privileged information.
> If you are not the addressee or authorized to receive this on behalf of
> the addressee you must not use, copy, disclose or take action based on this
> message or any information herein.
> If you have received this message in error, please advise the sender
> immediately by reply email and delete this message. Thank you.
>

-- 
This message may contain confidential and/or privileged information. 
If you are not the addressee or authorized to receive this on behalf of the 
addressee you must not use, copy, disclose or take action based on this 
message or any information herein. 
If you have received this message in error, please advise the sender 
immediately by reply email and delete this message. Thank you.

Mime
View raw message