stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lafernando <...@git.apache.org>
Subject [GitHub] stratos pull request: Fixing login error message in CLI
Date Mon, 03 Aug 2015 09:30:03 GMT
Github user lafernando commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/330#discussion_r36069108
  
    --- Diff: components/org.apache.stratos.cli/src/main/java/org/apache/stratos/cli/RestCommandLineService.java
---
    @@ -214,7 +215,7 @@ public void checkServerTrusted(java.security.cert.X509Certificate[]
certs, Strin
                         if (responseCode == 200) {
                             return true;
                         } else {
    -                        System.out.println("Invalid STRATOS_URL");
    +                        System.out.println("Invalid value is set for STRATOS_URL");
    --- End diff --
    
    Create an overloaded "printError" method, which doesn't take an exception object. Having
sysouts and another method to log errors makes it inconsistent on how you handle printing
of errors. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message