stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From imesh <...@git.apache.org>
Subject [GitHub] stratos pull request: Google compute engine load balancing support...
Date Thu, 13 Aug 2015 03:42:44 GMT
Github user imesh commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/419#discussion_r36938744
  
    --- Diff: components/org.apache.stratos.cartridge.agent/src/test/java/org/apache/stratos/cartridge/agent/test/JavaCartridgeAgentTest.java
---
    @@ -77,6 +77,7 @@
         private static final String PARTITION_ID = "partition-1";
         private static final String TENANT_ID = "-1234";
         private static final String SERVICE_NAME = "php";
    +    private static final String INSTANCE_ID = "instance-1";
         public static final String AGENT_NAME = "apache-stratos-cartridge-agent-4.1.0";
    --- End diff --
    
    Is this constant used outside this class? If not may be we can make it private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message