stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Imesh Gunaratne <im...@apache.org>
Subject Re: Improvements to Python cartridge agent artifact distribution
Date Sat, 19 Sep 2015 16:08:09 GMT
On Fri, Sep 18, 2015 at 12:31 AM, Akila Ravihansa Perera <ravihansa@wso2.com
> wrote:
>
>
> Few improvements were made to resolve these issues.
>  - Now PCA will run the commit job first. If the Git clone has not been
> done it will skip in that iteration.
>

Does this mean it will add all the files available in the given file path
to the remote git repository? What if the same is there in the remote git
repository and the file system?


>  - When Git checkout job is running, if there are any modifications in the
> working directory, checkout job will be skipped, allowing commit job to
> push those changes to remote repo first. Earlier when running the checkout
> job PCA will do a "git reset --hard" causing all modifications to vanish
> thus leading to potential data losses.
>

Assume this only happens if Auto Commit is enabled.


>  - When commit job is running it will stage all untracked files and commit
> the changes and do a "git pull --rebase" before pushing to remote repo.
> This will resolve any possible conflicts with the remote repo to a certain
> level.
>


>  - PCA will now clone the remote repo to a temporary location first
> instead of directly cloning at repository path. After clone is complete it
> will move all the files to repository path overwriting any existing files.
> The priority will be given to remote repo. This will avoid any potential
> problems that could arise because of missing artifacts when starting up the
> application process.
>
> +1


> Also I've written an integration test to PCA to cover these scenarios. It
> will assert whether a file gets removed from the remote repo when it is
> deleted locally.
>
> Awesome! Does this trigger in the build?

Thanks

-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos

Mime
View raw message