stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gayan Gunarathne <gay...@wso2.com>
Subject Re: Application ID length validation
Date Thu, 17 Sep 2015 17:09:49 GMT
Idea for using the application ID as a service name to clearly distinguish
the Kubernetes service against the application ID.If we are using other
unique identifier, we won't be identify service belongs to the application.

OTOH we use application ID to identify the application and IMO we can have
a meaningful name with in the length of 20 characters.

Thanks,
Gayan

On Thu, Sep 17, 2015 at 8:58 PM, Akila Ravihansa Perera <ravihansa@wso2.com>
wrote:

> +1 decoupling application id and kub8 service name. What if we repeatedly
> query the existing service names and increment the seq no until an
> available service name is found? This is what we do when generating pod
> names.
>
> On Thu, Sep 17, 2015 at 8:40 PM, Pubudu Gunatilaka <pubudug@wso2.com>
> wrote:
>
>> Hi Gayan,
>>
>> Can't we limit the Kubernetes service name rather than limiting the
>> application id. If we are deploying multiple applications, it would be
>> better if we can have meaningful name for the application ids. If we are
>> going to limit the kubernetes service name, we may have to come up with
>> another solution for that. We may not able to append the application id for
>> that.
>>
>> Thank you!
>>
>> On Thu, Sep 17, 2015 at 8:33 PM, Gayan Gunarathne <gayang@wso2.com>
>> wrote:
>>
>>> Added the logic to validate the application ID length.This is because we
>>> are using the application ID as a Kubernetes service name which supports
>>> up-to 24 characters.
>>>
>>> But I could enable the application ID validation length to 20 as
>>> integration test are failed due to integration test samples application ID
>>> is greater than 20.Thus I set the max_length constant to 40 for the moment
>>> and push the changes to the Stratos-4.1.x.
>>>
>>> Will change the integration test samples with shorter application ID and
>>> will update the application ID max length to 20.
>>>
>>> Thanks,
>>> Gayan
>>>
>>> --
>>>
>>> Gayan Gunarathne
>>> Technical Lead, WSO2 Inc. (http://wso2.com)
>>> Committer & PMC Member, Apache Stratos
>>> email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>
>>>
>>>
>>>
>>
>>
>>
>> --
>>
>> *Pubudu Gunatilaka*
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean.enterprise.middleware
>> mobile:  +94 77 4078049
>>
>
>
>
> --
> Akila Ravihansa Perera
> WSO2 Inc.;  http://wso2.com/
>
> Blog: http://ravihansa3000.blogspot.com
>



-- 

Gayan Gunarathne
Technical Lead, WSO2 Inc. (http://wso2.com)
Committer & PMC Member, Apache Stratos
email : gayang@wso2.com  | mobile : +94 775030545 <%2B94%20766819985>

Mime
View raw message