stratos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sinthuja <...@git.apache.org>
Subject [GitHub] stratos pull request: Metering ui change
Date Fri, 20 May 2016 11:45:07 GMT
Github user sinthuja commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/471#discussion_r64028572
  
    --- Diff: components/org.apache.stratos.manager.console/console/controllers/login/login.jag
---
    @@ -24,23 +24,29 @@ var log = new Log("controller.login"),
             util = require('/controllers/rest/rest_calls.jag'),
             server = new carbon.server.Server(),
             conf = carbon.server.loadConfig('carbon.xml'),
    -        offset = conf.*::['Ports'].*::['Offset'].text(),
    -        hostName = conf.*::['HostName'].text().toString();
    +        offset = conf. *::['Ports']. *::['Offset'].text(),
    +        hostName = conf. *::['HostName'].text().toString(),
    +        conf = carbon.server.loadConfig('thrift-client-config.xml'),
    +        dasConfig = conf. *::['config'].(name == "das"),
    +        dasStatsPublisherEnabled = dasConfig.statsPublisherEnabled.text();
    +
     
     if (hostName === null || hostName === '') {
         hostName = 'localhost';
     }
     
     var httpPort = 9763 + parseInt(offset, 10),
    -    httpsPort = 9443 + parseInt(offset, 10);
    +        httpsPort = 9443 + parseInt(offset, 10);
    --- End diff --
    
    It's recommended to declare the vars separately without declaring as single statement.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message