struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dariusz Wojtas (JIRA)" <>
Subject [jira] Commented: (WW-1536) TabbedPanel improvements
Date Wed, 06 Dec 2006 07:35:57 GMT
    [ ] 
Dariusz Wojtas commented on WW-1536:

One more comment on the 'date' issue. It seems to prove that there were problems with the
current implementation of setting date headers.

I am now using the patched version of the code (see attached patch). Works nicely as expected.
But recently I called my application from another machine that was not accessing the app after
patching it.
It has sent the 'If-Modified-Since' header with wrong value (as it was set by the orig Struts
code, locale PL) and the
    long ifModifiedSince = request.getDateHeader("If-Modified-Since");
line in the patched code threw an exception (invalid format).

I think that there could be extra try/catch block added in the patched code to prevent exception
if somebody used it before. In case of exception - set ifModifiedSince to -1

> TabbedPanel improvements
> ------------------------
>                 Key: WW-1536
>                 URL:
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Views
>    Affects Versions: 2.0.2
>            Reporter: Musachy Barroso
>            Priority: Minor
>             Fix For: 2.0.x
>         Attachments: FilterDispatcher_patch.patch
> 1) Does it really need to download 500+ kB of javascript and related
> code to display a set of empty tabs? Can it be compressed somehow? Any
> switches for that?
> 2) Why does that javascript and related code get reloaded every time?
>    I try to enter the page with tabs again (not forcing reload with SHIFT) and
>    all that stuff is fetched again.
>    Can it be something with http headers?
>    The total amount of data that is sent is really frustrating me.
> 3) In addition to that I could observe 16 multiple requests for
>       GET /myApp/struts/xhtml/styles.css HTTP/1.1
>    to display single HTML page with 7 remote panels
>    (test, all panels referring the same simple page with 1 test
> sentence - nothing more).
> 4) It is not written anywhere in docs - but these tabs do not work if the S2
>    application uses 'html' for action extension (overriding the default).
>    Some of the resources returned by Struts for tabbedPanel also end
> with 'html'
>    and the struts controller sees a problem.
>        GET /myApp/struts/dojo/src/widget/templates/TabContainer.html HTTP/1.1
>    I can only see a stacktrace that such action is not defined in my app,
>    dojo does not get such page and instead of tabs I can only see
> error message
>    in the browser.
>    After I changed the extension for my actions to something else -
> it started to work.
>    But it took me 30 minutes to understand the problem.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:


View raw message