struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Antonio Petrelli (JIRA)" <j...@apache.org>
Subject [jira] Assigned: (SB-102) ComponentDefinitionsImpl incorectly recurses on child rather than parent definition
Date Tue, 19 Dec 2006 07:45:57 GMT
     [ http://issues.apache.org/struts/browse/SB-102?page=all ]

Antonio Petrelli reassigned SB-102:
-----------------------------------

    Assignee: Antonio Petrelli

> ComponentDefinitionsImpl incorectly recurses on child rather than parent definition
> -----------------------------------------------------------------------------------
>
>                 Key: SB-102
>                 URL: http://issues.apache.org/struts/browse/SB-102
>             Project: Sandbox
>          Issue Type: Bug
>          Components: Tiles
>    Affects Versions: 2.0
>            Reporter: Joe Pemberton
>         Assigned To: Antonio Petrelli
>
> I believe that ComponentDefinitionsImpl.resolveInheritance(ComponentDefinition, Locale)
incorrectly recurses on the child definition instead of the parent definition.  Since it does
not call resolveInheritance() on the parent definition, the child does not inherit any of
the parent's attributes unless the parent has already been visited.
> The very simple fix that took me much head scratching and guessing to find:
> --- tiles-core/src/main/java/org/apache/tiles/definition/ComponentDefinitionsImpl.java
 (revision 488454)
> +++ tiles-core/src/main/java/org/apache/tiles/definition/ComponentDefinitionsImpl.java
 (working copy)
> @@ -329,7 +329,7 @@
>              throw new NoSuchDefinitionException(msg);
>          }
> -        resolveInheritance(definition, locale);
> +        resolveInheritance(parent, locale);
>          overload(parent, definition);
>      }
> p.s. keep up the great work, guys.  I can't wait to deploy Tiles2+Struts2 in production.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message