struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jasper Rosenberg (JIRA)" <j...@apache.org>
Subject [jira] Created: (WW-1807) FreemarkerResult location masking
Date Tue, 13 Mar 2007 14:31:51 GMT
FreemarkerResult location masking
---------------------------------

                 Key: WW-1807
                 URL: https://issues.apache.org/struts/browse/WW-1807
             Project: Struts 2
          Issue Type: Task
          Components: Views
    Affects Versions: 2.0.6
            Reporter: Jasper Rosenberg
            Priority: Minor


FreemarkerResult.doExecute() takes a location parameter.  

FreemarkerResult also has a location member variable.

In doExecute(), it first assigns the parameter location to the member variable location.

It then conditionally alters the value of the parameter location.  It isn't clear if this
was the intent or if the intent was to modify the member variable.

To make things even more confusing, the parent class StrutsResultSupport also has a private
location member variable.

At the very least, it would be helpful if these three "location" variables were given unique
names so it could be clear to a reader what the intended behavior is.

Thanks!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message