struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Don Brown (JIRA)" <>
Subject [jira] Resolved: (WW-1649) css_xhtml template produces invalid xhtml
Date Sun, 27 May 2007 13:12:43 GMT


Don Brown resolved WW-1649.

       Resolution: Fixed
    Fix Version/s:     (was: 2.1.x)
         Assignee: Don Brown

I fixed the POST issue and the spaces before the />  The id/name issue will have to wait
as that is a pretty big can of worms that deserves its own ticket.  An innocent change to
be more compliant breaks all sorts of stuff, as I found out once when I changed Struts 1.

> css_xhtml template produces invalid xhtml
> -----------------------------------------
>                 Key: WW-1649
>                 URL:
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: 2.0.1
>            Reporter: Gina Accawi
>         Assigned To: Don Brown
>            Priority: Minor
>             Fix For: 2.0.8
> XHTML produced using css_xhtml template is not valid XHTML. I have found two basic issues,
and one suggested modification:
> 1.  Form method should be "post" not "POST".
> 2.  The attribute "name" is deprecated in favor of using "id". This issue seems to be
more difficult to deal with given that there seem to be many places depending on name. The
following elements should NOT use name attribute:  a, applet, form, frame, iframe, img, and
map. However, it should also be noted that many Javascripts, including some Ajax toolkits,
rely heavily on the DOM method getElementById rather than getting them by name, making it
more important to encourage the use of id over name.
> 3.  This one is more the for the sake of using xml/object binding tools, wsdl generators
and such:  When creating empty tags, the /> should have a space between it and the content
like so:
> Less good <br/>
> More good <br />
> I have not looked much deeper than a simple form with two selects, so I cannot say if
I may be missing others. I use the W3C XHTML validator often in testing,  which makes it fairly
easy to detect problems with xhtml validity.
> thanks

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message