struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anonymous (JIRA)" <j...@apache.org>
Subject [jira] Updated: (WW-187) GenericDispatcher does not pop actions from ValueStack correctly
Date Mon, 11 Jun 2007 07:48:28 GMT

     [ https://issues.apache.org/struts/browse/WW-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]


    Status: Resolved  (was: Closed)

> GenericDispatcher does not pop actions from ValueStack correctly
> ----------------------------------------------------------------
>
>                 Key: WW-187
>                 URL: https://issues.apache.org/struts/browse/WW-187
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Dispatch
>    Affects Versions: WW 1.3
>            Reporter: Dick Zetterberg
>            Assignee: Dick Zetterberg
>            Priority: Minor
>             Fix For: WW 1.4
>
>
> The GenericDispatcher does not pop actions from the ValueStack correctly when used in
a servlet environment (using the ServletDispatcher that is).
> It is confused because the Valuestack is actually set AFTER the call to the prepareContext
method (with the call to ServletActionContext.setContext)
> So when the GenericDispatcher tries to pop actions from the stack in the finalizeContext
method it is looking at the old stack that has not been used so there is never anything to
pop.
> The ServletDispatcher pops one action when it is finished but if you have executed a
chain of actions then the rest of them will remain on the stack.
> This may not have a big impact, but the current code is wrong and confusing. So either
it should be fixed or else it would be better not to clean up anything at all from the stack.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message