struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Benedict (JIRA)" <j...@apache.org>
Subject [jira] Closed: (STR-2239) [struts] ModuleUtils/TagUtils: setInstance() missing
Date Thu, 15 Nov 2007 06:13:33 GMT

     [ https://issues.apache.org/struts/browse/STR-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paul Benedict closed STR-2239.
------------------------------

    Resolution: Won't Fix
      Assignee:     (was: Struts Developers)

It is generally a bad idea to create instance methods for static factory classes. What you
really want is an enhancement in the Controller, not in utility classes.

> [struts] ModuleUtils/TagUtils: setInstance() missing
> ----------------------------------------------------
>
>                 Key: STR-2239
>                 URL: https://issues.apache.org/struts/browse/STR-2239
>             Project: Struts 1
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.4
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Lars Beuster
>            Priority: Minor
>
> Why is there no setInstance() method on both classes and why is the
> instance-member final. If I cannot change the behavior of both classes then
> there's not need to use the singleton and you could have left the static-methods.
> I have a different mapping in my web.xml (/servletname/* -> ActionServlet). But
> this mapping isn't supported by Struts if I have more than one Module, because
> ModuleUtils.getModuleName()-method cannot handle this.
> Thanks Lars

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message