struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Husted (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (WW-2282) Apply patch to Struts2 core module on performance issues reported by FindBugs
Date Fri, 02 Nov 2007 00:36:42 GMT

     [ https://issues.apache.org/struts/browse/WW-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Husted resolved WW-2282.
----------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.1

r591174

OK, I applied these changes, since they are less likely to conflict with other changes that
we make, and patch conflict always happens anyway. 

Feel free to submit other patches, but we may have to deal with some of the older patches
first. 

-Ted.


> Apply patch to Struts2 core module on performance issues reported by FindBugs 
> ------------------------------------------------------------------------------
>
>                 Key: WW-2282
>                 URL: https://issues.apache.org/struts/browse/WW-2282
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.1.0
>            Reporter: Giovanni Azua Garcia
>            Assignee: Ted Husted
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: Struts2CorePerfPatch_ToRev590856.diff, Struts2CorePerfPatch_ToRev590856.zip
>
>
> Post to DEV list:
> Recently I was following some threads in the Struts users list about performance issues
in S2 and was curious to look at Struts code. Running findBugs evidences many small improvements
that would overall and cheaply improve S2 performance e.g.
> - In many places it is continuously creating large number of small objects by using new
rather than valueOf. 
> http://findbugs.sourceforge.net/bugDescriptions.html#DM_NUMBER_CTOR
> - FindBugs spotted several places using non static inner classes unnecessarily.
> - Also a few places use inneficiently keySet iterators on maps rather than using entrySet.
> - Calling toString on String types.
> Good idea probably adding findbugs to the pom reporting.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message