struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Gorobets (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-1859) Namespace attribute should not rely on portlet URLs in <s:form> tag
Date Wed, 09 Jan 2008 15:26:04 GMT

    [ https://issues.apache.org/struts/browse/WW-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42960#action_42960
] 

Oleg Gorobets commented on WW-1859:
-----------------------------------

Sure, URLs are different, but code in Form tag tries to determine 'namespace' attribute with

addParameter("namespace", result.substring(0, slash));

which relies on special URL formatting and influences form tag representation. See last patch
for reference.

> Namespace attribute should not rely on portlet URLs in <s:form> tag
> -------------------------------------------------------------------
>
>                 Key: WW-1859
>                 URL: https://issues.apache.org/struts/browse/WW-1859
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Portlet, Plugin - Tags
>    Affects Versions: 2.0.6
>            Reporter: Oleg Gorobets
>             Fix For: 2.1.1
>
>         Attachments: WW-FormTag.patch, WW-FormTag2.patch, WW-FormTag3.patch
>
>
> Current implementation of <s:form> tag  uses portlet URL to retrieve namespace
attribute. This approach can be harmful when portlet URL returns path with the context prefix,
e.g. /context/namespace/Action.action or custom (non-struts) URL. Instead it will be much
better to use <s:form> 'namespace' attribute with the highest priority and then (if
not defined) current namespace (see patch for details).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message