struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niall Pemberton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STR-3151) messagesPresent should not alter ActionMessages.accessed flag
Date Wed, 04 Jun 2008 17:11:06 GMT

    [ https://issues.apache.org/struts/browse/STR-3151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44018#action_44018
] 

Niall Pemberton commented on STR-3151:
--------------------------------------

OK I got the point about whether its actually accessed or not - but it seems like this is
just some theoretical issue thats probably never going to happen in practice - which is why
I asked for the actual scenario or use-case where this is causing you an issue.

Would seem strange to me to get to the view rendering stage, rendering something conditional
on the messages being there - but still want the messages preserved after the next whole cycle
of request processing has completed.


> messagesPresent should not alter ActionMessages.accessed flag
> -------------------------------------------------------------
>
>                 Key: STR-3151
>                 URL: https://issues.apache.org/struts/browse/STR-3151
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Taglibs
>    Affects Versions: 1.3.8
>         Environment: n/a
>            Reporter: T.J. Hill
>            Assignee: Paul Benedict
>             Fix For: 1.4.0
>
>
> 20080603 12:53
> The html|nested:messagesPresent tags set ActionMessages.accessed flag to true when interrogating.
> Currently, MessagesPresentTag calls the methods get() and get(String) of ActionMessages
to determine if any messages exist.  However, both get(...) methods in ActionMessages set
the accessed field to true.  So any subsequent call to ActionMessages.isAccessed() by external
code will get true, regardless if the messages were truly consumed.
> Below is the current condition method in MessagesPresentTag:
>     protected boolean condition(boolean desired)
>         throws JspException {
>         ActionMessages am = null;
>         String key = name;
>         if ((message != null) && "true".equalsIgnoreCase(message)) {
>             key = Globals.MESSAGE_KEY;
>         }
>         try {
>             am = TagUtils.getInstance().getActionMessages(pageContext, key);
>         } catch (JspException e) {
>             TagUtils.getInstance().saveException(pageContext, e);
>             throw e;
>         }
>         Iterator iterator = (property == null) ? am.get() : am.get(property); // HERE
is the issue -- using get(...) methods will cause the accessed property of ActionMessages
to be set to true.
>         return (iterator.hasNext() == desired);
>     }
> Perhaps the following change would be appropriate to resolve the issue.
> Modify the condition(boolean) method in MesssagesPresentTag to call the existing ActionMessages.size()
[when property not specified] and the exsiting ActionMessages.size(String) method above [when
property specified]:
>  
>      protected boolean condition(boolean desired)
>          throws JspException {
>          ActionMessages am = null;
>  
>          String key = name;
>  
>          if ((message != null) && "true".equalsIgnoreCase(message)) {
>              key = Globals.MESSAGE_KEY;
>          }
>  
>          try {
>              am = TagUtils.getInstance().getActionMessages(pageContext, key);
>          } catch (JspException e) {
>              TagUtils.getInstance().saveException(pageContext, e);
>              throw e;
>          }
>  
>  			// --- CURRENT ---
>          //Iterator iterator = (property == null) ? am.get() : am.get(property);
>          //return (iterator.hasNext() == desired);
>          
>          // +++ SUGGESTED +++
>          int present = (property == null) ? am.size() : am.size(property);
>          return ((present > 0) == desired);
>     }	
>     
>  Thanks - TH

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message