struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Belingueres (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-2850) paramsPrepareParams stack should execute checkbox interceptor earlier
Date Mon, 27 Oct 2008 13:16:38 GMT

    [ https://issues.apache.org/struts/browse/WW-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44872#action_44872
] 

Gabriel Belingueres commented on WW-2850:
-----------------------------------------

May I say that removing the current checkbox interceptor (the one after the prepare interceptor)
may change current semantics for some applications because the prepare interceptor execute
action code that can potentially set action's instance variables used for storing parameter
values.

> paramsPrepareParams stack should execute checkbox interceptor earlier
> ---------------------------------------------------------------------
>
>                 Key: WW-2850
>                 URL: https://issues.apache.org/struts/browse/WW-2850
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 2.1.2
>            Reporter: Sami Dalouche
>
> The current paramsPrepareParams interceptor executes the checkbox interceptor late in
the chain, which results in the 2 params interceptor not applying the same parameter set if
there are checkboxes.
> Instead, it should look like :
> <interceptor-stack name="paramsPrepareParamsStack">
>                 <interceptor-ref name="exception"/>
>                 <interceptor-ref name="alias"/>
>                 <interceptor-ref name="i18n"/>
>                 <interceptor-ref name="checkbox"/>
>                 <interceptor-ref name="params"/>
>                 <interceptor-ref name="servletConfig"/>
>                 <interceptor-ref name="prepare"/>
>                 <interceptor-ref name="chain"/>
>                 <interceptor-ref name="modelDriven"/>
>                 <interceptor-ref name="fileUpload"/>
>                 <!-- BAD <interceptor-ref name="checkbox"/>-->
>                 <interceptor-ref name="staticParams"/>
>                 <interceptor-ref name="actionMappingParams"/>
>                 <interceptor-ref name="params"/>
>                 <interceptor-ref name="conversionError"/>
>                 <interceptor-ref name="validation">
>                     <param name="excludeMethods">input,back,cancel</param>
>                 </interceptor-ref>
>                 <interceptor-ref name="workflow">
>                     <param name="excludeMethods">input,back,cancel</param>
>                 </interceptor-ref>
>             </interceptor-stack>
> The additional bonus is that you get rid of stupid OGNL exceptions trying to set __checkbox_*
parameters during the first params execution :)
> regards,
> Sami Dalouche

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message