struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Benedict (JIRA)" <>
Subject [jira] Closed: (STR-3096) bufferSize in controller configuration does not work
Date Sun, 21 Dec 2008 06:14:36 GMT


Paul Benedict closed STR-3096.

       Resolution: Won't Fix
    Fix Version/s:     (was: Pending Review)

The bufferSize attribute used to be configure BufferedMultipartInputStream, but that class
was deprecated in 1.2.x and later removed:


Although a worthy suggestion, my investigation shows that byte-buffering implementations may
rely on it. The attribute shall remain.

> bufferSize in controller configuration does not work
> ----------------------------------------------------
>                 Key: STR-3096
>                 URL:
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.9
>         Environment: simple struts web application with file-upload feature
>            Reporter: AdNovum
>            Assignee: Paul Benedict
>            Priority: Minor
> Controller configuration allows to set a buffer size to be used when doing file uploads
(described in online documentation):
> <controller
> 	className="..."
> 	processorClass="..."
> 	inputForward="true"
> 	bufferSize="102400"
> >
> ...
> Unfortunately it seems that this value is never propagated to the implementation classes
(CommonsMultipartRequestHandler, DiskFileUpload and FileUploadBase)
> from struts and apache commons-fileupload. So the default buffersize (4K) is used which
could possibly lead to bad performance (high CPU usage).
> Either the bufferSize should take effect or it should not be available as a configuration

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message