struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Newton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-2896) Various generics and StringBuilder fixes
Date Mon, 01 Dec 2008 10:10:36 GMT

    [ https://issues.apache.org/struts/browse/WW-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45063#action_45063
] 

Dave Newton commented on WW-2896:
---------------------------------

4.
The change to PortletActionRedirectResult shows how using generics cleans up code, but the
spacing looks like it got skewed. (Also, it appears that not everyone was keeping with the
78 char width in the trunk copy)

Oh, were the StringBuilder patches only partially applied? I fixed PortletActionRedirectResult
yesterday and discovered IDEA is removing blank chars at the end of lines so the commit generated
a bunch of noise. I know it's noise, but... meh.

I'm not a big fan of 78-chars-per-line these days, either :( not practical in real Java code.
We can move this to dev list to continue.

> Various generics and StringBuilder fixes
> ----------------------------------------
>
>                 Key: WW-2896
>                 URL: https://issues.apache.org/struts/browse/WW-2896
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.1.2
>            Reporter: Mathias Bogaert
>             Fix For: 2.1.3
>
>         Attachments: variousgenericsbuilder.patch, variousgenericsbuilder.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message