struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Benedict (JIRA)" <j...@apache.org>
Subject [jira] Commented: (STR-3169) Infinite loop in wildcard mapping
Date Sun, 21 Dec 2008 07:52:36 GMT

    [ https://issues.apache.org/struts/browse/STR-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45353#action_45353
] 

Paul Benedict commented on STR-3169:
------------------------------------

I solved the issue and have unit tests to prevent the regression.

So what to do when this happens? Obviously, the action mapping can never successfully be valid.
It is an edge case where a couple of requests are incompatible with the action mapping.

I see two possible outcomes:
1) Do not return the action config and log a warning
2) Throw an IllegalStateException.

I think #1 is most appropriate since the request truly has no way of being processed. It's
not a system error like #2 so it should be handled gracefully like any other bad request.

Opinions?

> Infinite loop in wildcard mapping
> ---------------------------------
>
>                 Key: STR-3169
>                 URL: https://issues.apache.org/struts/browse/STR-3169
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.3.9
>            Reporter: ryabko
>            Assignee: Paul Benedict
>            Priority: Critical
>             Fix For: 1.3.11, 1.4.0
>
>
> I have that mapping:
>     <action path="/page-*"
>                    type="ru.ryabko.actions.ShowPage"
>                    parameter="{1}">
>                <forward name="success" path="/page.jsp"/>
>     </action>
> The application hang up in WildcardHelper.match() method if i construct URL like that:
>               http://localhost/page-{0}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message