struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Newton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-3010) s:iterator fails to iterate over collections containing null
Date Thu, 16 Apr 2009 15:47:06 GMT

    [ https://issues.apache.org/struts/browse/WW-3010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45961#action_45961
] 

Dave Newton commented on WW-3010:
---------------------------------

But apps coded to expect "correct" behavior will break, because "correct" behavior isn't what
actually happens. Code changes that break existing behavior, "correct" or not, can't just
be thrown in willy-nilly, "dangerous mentality" or not.

> s:iterator fails to iterate over collections containing null
> ------------------------------------------------------------
>
>                 Key: WW-3010
>                 URL: https://issues.apache.org/struts/browse/WW-3010
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.14
>         Environment: any
>            Reporter: Daniel Baldes
>
> When using the struts2 taglib's iterator tag to iterate over a collection which contains
nulls, the current value ("id") is not set to null, but to the value it had in the last iteration
before. This behaviour is explicitly coded without any obvious reason. See IteratorComponent.java
from line 219:
>             if ((id != null) && (currentValue != null)) {
>                 //pageContext.setAttribute(id, currentValue);
>                 //pageContext.setAttribute(id, currentValue, PageContext.REQUEST_SCOPE);
>                 stack.getContext().put(id, currentValue);
>             }
> Expected behaviour: just iterate over the null values as a plain java iterator would.
> If nulls are forbidden for some important reason, it should throw an execption, but not
return a wrong value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message