struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wes Wannemacher (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-3150) TokenSessionStoreInterceptor fails with NPE when no token is provided.
Date Thu, 04 Jun 2009 19:40:42 GMT

    [ https://issues.apache.org/struts/browse/WW-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46337#action_46337
] 

Wes Wannemacher commented on WW-3150:
-------------------------------------

sorry, you are right. I had even looked at that and thought it might NPE as well. Anyways,
I changed the Map implementation in a different unit test (you can check the SVN diff to see
which one) and sure enough an NPE cropped up, so hopefully this'll be squashed out for good
now.

> TokenSessionStoreInterceptor fails with NPE when no token is provided.
> ----------------------------------------------------------------------
>
>                 Key: WW-3150
>                 URL: https://issues.apache.org/struts/browse/WW-3150
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>         Environment: N/A
>            Reporter: James Peltzer
>            Assignee: Wes Wannemacher
>             Fix For: 2.1.7
>
>
> TokenSessionStoreInterceptor fails when no token is provided.
> java.lang.NullPointerException at java.util.TreeMap.getEntry(Unknown Source) at java.util.TreeMap.get(Unknown
Source) at org.apache.struts2.util.TokenHelper.getToken(TokenHelper.java:101) at org.apache.struts2.interceptor.TokenSessionStoreInterceptor.handleInvalidToken(TokenSessionStoreInterceptor.java:117)
at org.apache.struts2.interceptor.TokenInterceptor.doIntercept(TokenInterceptor.java:141)
at com.opensymphony.xwork2.interceptor.MethodFilterInterceptor.intercept(MethodFilterInterceptor.java:87)

> ...
> It looks like it could be solved if the TokenHelper class checks to make sure it isn't
trying to look up a null token name and just returns null immediately.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message