struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Jiang (JIRA)" <j...@apache.org>
Subject [jira] Created: (WW-3266) getFieldValue() method of ValueStackDataSource uses getDescription() to get field value may not appropriate
Date Sun, 27 Sep 2009 14:56:48 GMT
getFieldValue() method of ValueStackDataSource uses getDescription() to get field value may
not appropriate
-----------------------------------------------------------------------------------------------------------

                 Key: WW-3266
                 URL: https://issues.apache.org/struts/browse/WW-3266
             Project: Struts 2
          Issue Type: Improvement
          Components: Plugin - JasperReports
    Affects Versions: 2.1.6
         Environment: JasperReports 3.6
Groovy 1.5.5
JDK 1.6 (MAC JDK) 

            Reporter: Matt Jiang


Current implementation:
String expression = field.getDescription();

if (expression == null) {
    //Description is optional so use the field name as a default
    expression = field.getName();
}

Object value = valueStack.findValue(expression);

Recommended implementation :
String expression = field.getName();
Object value = valueStack.findValue(expression);

Reason:
In JasperReports, a description of a field is just like a documentation for this field. So
it may not good to use it as expression.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message