struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Siman (JIRA)" <j...@apache.org>
Subject [jira] Commented: (WW-3232) New Cookie Interceptor
Date Thu, 03 Sep 2009 10:31:19 GMT

    [ https://issues.apache.org/struts/browse/WW-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46717#action_46717
] 

Alex Siman commented on WW-3232:
--------------------------------

Interesting approach to add/remove cookies.

Why did you not use all properties of javax.servlet.http.Cookie in your Cookie annotation?
http://www.docjar.com/html/api/javax/servlet/http/Cookie.java.html

What if create Cookies annotation for Map<String, String> property?
Concept example:

class CookieAction {
	@Cookies(
		@Cookie(name="cookieName1", timeToLive=100, path="xxx"),
		@Cookie(name="cookieName2", timeToLive=200, path="yyy")
	)
	private Map<String, String> twoCookies;
	
	@Cookies
	private Map<String, String> allCookies;
	
	// If (allCookies.get(key) == null) remove cookie.
	// If (allCookies == null || allCookies.size() < 1) remove all cookies.
}

What if make Cookie.name not required? Simply use property name as cookie name.

> New Cookie Interceptor
> ----------------------
>
>                 Key: WW-3232
>                 URL: https://issues.apache.org/struts/browse/WW-3232
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.1.6
>            Reporter: carlo scarioni
>            Assignee: carlo scarioni
>         Attachments: struts-cookie-interceptor.tar.gz
>
>
> Hello, I've developed for my current project a simple Cookie Interceptor. It's like the
one in the distribution but different, :)
> It works by annotating in the action with a @Cookie(name="cookieName",timeToLive=100,path="xxx")
a String property.
> The Interceptor (Which is also a PreResultListener) Scans the action. if it finds a @Cookie
annotation it injects the cookie value into the action's property. When the action is executed,
the interceptor's beforeResultMethod scans the action again and the values from properties
annotated with @Cookie are saved in the response's cookies.
> This is the basic idea, than using just the getters and setters in the action you can
retrieve and set a cookie..
> I would love to share this simple interceptor, i would love to see a little of my code
added to your project :D ... what can i do for you to see the code and if it's something you
like, submit it... thanks..

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message