struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Krüger (JIRA) <j...@apache.org>
Subject [jira] Commented: (WW-3318) throwExceptionOnFailure=true doesn't detect undefined property burried in OGNL
Date Mon, 12 Apr 2010 06:37:42 GMT

    [ https://issues.apache.org/jira/browse/WW-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855860#action_12855860
] 

Andreas Krüger commented on WW-3318:
------------------------------------

Which flag is only used for development purpose?
Do you mean "devMode" or "throwExceptionOnFailure"?

If "throwExceptionOnFailure", I could not disagree more.

When a method we had been building on is no longer present through some incomplete rafactoring,

this is a grave bug

and we want the application to fail as cleanly as possible.

Preferably at compile or deploy time. If that is not possible, with a big, loud exception
at runtime.

Simply going on as if nothing were wrong isn't an option for us.
This simply produces the wrong answers at the user interface.
The user relies on information she sees, but the information is simply wrong.

All of that remains true when the application has made it to the production environment
with the bug undetected. Even in production environment, wrong answers can not be tolerated.

A comment in the log does not really solve the problem.

Have you tried to reproduce?
Where exactly is your problem in reproducing?
Which additional details would you like to have?

> throwExceptionOnFailure=true doesn't detect undefined property burried in OGNL
> ------------------------------------------------------------------------------
>
>                 Key: WW-3318
>                 URL: https://issues.apache.org/jira/browse/WW-3318
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Value Stack
>    Affects Versions: 2.1.8
>            Reporter: Andreas Krüger
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.0
>
>
> Setup:
> struts.el.throwExceptionOnFailure=true in struts.properties
> In the value stack, there is no object which has any property "xxx"
> The JSP has  <s:property value="xxx == null ? 'Not yet determined' : xxx" />
> Expected behaviour: As the property xxx is not defined, this should throw an exception.
> Behaviour seen: The string "Not yet determined" gets inserted into the HTML output as
if nothing were wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message