struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Thrasher (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (WW-3426) ServletRedirectResult and ServletActionRedirectResult should support #anchor URI syntax
Date Thu, 01 Apr 2010 07:05:27 GMT

    [ https://issues.apache.org/jira/browse/WW-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852268#action_12852268
] 

Jason Thrasher edited comment on WW-3426 at 4/1/10 7:04 AM:
------------------------------------------------------------

The attached patch provides #anchor URI support for ServletRedirectResult and ServletActionRedirectResult.
 Unit tests are included as well.

The patch was created against SVN r929846, and should be applied from:
 http://svn.apache.org/repos/asf/struts/struts2/trunk/core

Example usage in struts.xml action result:

<result name="success" type="redirectAction">
	<param name="namespace">/space</param>
	<param name="actionName">myAction</param>
	<param name="anchor">FRAGMENT</param>
	<param name="param1">${param1}</param>
</result>



      was (Author: thrasher):
    The attached patch provides #anchor URI support for ServletRedirectResult and ServletActionRedirectResult.
 Unit tests are included as well.

Example usage in struts.xml action result:

<result name="success" type="redirectAction">
	<param name="namespace">/space</param>
	<param name="actionName">myAction</param>
	<param name="anchor">FRAGMENT</param>
	<param name="param1">${param1}</param>
</result>

  
> ServletRedirectResult and ServletActionRedirectResult should support #anchor URI syntax
> ---------------------------------------------------------------------------------------
>
>                 Key: WW-3426
>                 URL: https://issues.apache.org/jira/browse/WW-3426
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Dispatch Filter
>    Affects Versions: 2.1.8.1
>            Reporter: Jason Thrasher
>         Attachments: WW-3426-core-RedirectResult.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Expected URI syntax includes an "#anchor", as documented here:
>     http://labs.apache.org/webarch/uri/rfc/rfc3986.html#fragment
>     "A fragment identifier component is indicated by the presence of a number sign ("#")
character and terminated by the end of the URI."
> ServletRedirectResult's current implementation allows anchor fragments to be used only
if there are no query parameters present for the RedirectResult.  In this case, the location
param can be specified for a ServletRedirectResult with a #anchor suffix.  However this does
not work when using query parameters.  ServletActionRedirectResult does not support #anchor
due to runtime discovery of the target URI based on the actionName, namespace, and method.
> Anchor fragments should be generally supported in redirection.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message