struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leigh Anderson (JIRA)" <j...@apache.org>
Subject [jira] Updated: (WW-3461) Don't hold locks as long when creating validators in AnnotationActionValidatorManager
Date Mon, 28 Jun 2010 09:46:50 GMT

     [ https://issues.apache.org/jira/browse/WW-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Leigh Anderson updated WW-3461:
-------------------------------

    Attachment: validatormanager.patch

> Don't hold locks as long when creating validators in AnnotationActionValidatorManager
> -------------------------------------------------------------------------------------
>
>                 Key: WW-3461
>                 URL: https://issues.apache.org/jira/browse/WW-3461
>             Project: Struts 2
>          Issue Type: Improvement
>    Affects Versions: 2.1.6
>            Reporter: Leigh Anderson
>         Attachments: validatormanager.patch
>
>
> Under load, the lock held in AnnotationActionValidatorManager.getValidators on validatorCache
becomes contended. This lock is currently held while all the validators are created. The attached
patch reduces the scope of the lock to just doing the cache lookup + taking a defensive copy
of the list of validators for that key.  This improved throughput and latency in our tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message