struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurizio Cucchiara (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3711) StrutsSpringTransactionalTestCase - adding transactional behaviour to StrutsSpringTestCase
Date Thu, 24 Nov 2011 13:04:41 GMT

    [ https://issues.apache.org/jira/browse/WW-3711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156680#comment-13156680
] 

Maurizio Cucchiara commented on WW-3711:
----------------------------------------

Hi Miguel,
I'm just a little doubtful about your patch:
* there are many way to achieve what you described before (your is one of those and it could
be a matter of taste)
* you used Spring SimpleJdbcTemplate, but many users might use HibernateTemplate, JPATemplate,
or whatever.
* you used StrutsSpringTestCase which basically is based on Junit3, there is a [StrutsSpringJUnit4TestCase|http://svn.apache.org/repos/asf/struts/struts2/trunk/plugins/junit/src/main/java/org/apache/struts2/StrutsSpringJUnit4TestCase.java]
class which allows to use Spring annotations.
                
> StrutsSpringTransactionalTestCase - adding transactional behaviour to StrutsSpringTestCase
> ------------------------------------------------------------------------------------------
>
>                 Key: WW-3711
>                 URL: https://issues.apache.org/jira/browse/WW-3711
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Unit Tests
>    Affects Versions: 2.2.3.1
>            Reporter: Miguel Almeida
>              Labels: spring, struts2, test-patch
>         Attachments: StrutsSpringTransactionalAbstractTest.java
>
>
> From the mailing list thread:
> I'm using StrutsSpringTestCase for some under-the-skin tests.
> However, I felt the need to set up my database for a test. My tests that need the database
extend from AbstractTransactionalJUnit4SpringContextTests, which makes them transactional.
> I therefore created a StrutsSpringTransactionalTestCase that merges the behaviour of
both StrutsSpringTestCase and AbstractTransactionalJUnit4SpringContextTests. I currently just
copy-pasted the relevant information from AbstractTransactionalJUnit4SpringContextTests.
> I'd like you to take a look at it and comment on whether it makes sense to include this
in Struts. If so, feel free to use my contribution.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message