struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3696) XWork-Core JUnit Test Failure: com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2( )
Date Tue, 01 Nov 2011 22:51:41 GMT

    [ https://issues.apache.org/jira/browse/WW-3696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141718#comment-13141718
] 

Hudson commented on WW-3696:
----------------------------

Integrated in Struts2 #368 (See [https://builds.apache.org/job/Struts2/368/])
    WW-3696 - Work-Core JUnit Test Failure: com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2(
) (contributed by Jeff Black)

mcucchiara : 
Files : 
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/DefaultValidatorFileParser.java

                
> XWork-Core JUnit Test Failure: com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2(
)
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3696
>                 URL: https://issues.apache.org/jira/browse/WW-3696
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Other, Unit Tests
>            Reporter: JB
>            Assignee: Maurizio Cucchiara
>            Priority: Trivial
>              Labels: dtd, junit, parse, xwork
>             Fix For: 2.3
>
>         Attachments: com.opensymphony.xwork2.validator.DefaultValidatorFileParser.patch
>
>
> When I ran the tests on XWork-Core project the following test was failing:
> {code}
>     com.opensymphony.xwork2.validator.DefaultValidatorFileParserTest.testParserWithBadXML2()
> {code}
> The XML file the test attempts to validate is:
> {code}
>     com.opensymphony.xwork2.validator.validators-fail.xml
> {code}
> The DTD information contained within the validators-fail.xml file is:
> {code:xml}
>     <!DOCTYPE validators PUBLIC
>         "-//Apache Struts//XWork Validator Config 1.0//EN"
>         "http://struts.apache.org/dtds/xwork-validator-config-1.0.dtd">
> {code}
> However...
> In class *com.opensymphony.xwork2.validator.DefaultValidatorFileParser* and method *parseActionValidatorConfigs()*...
> The above DTD is not present.
> After adding the DTD to the *parseActionValidatorConfigs* method, the test succeeds.
 In fact 100% of the tests then succeed.
> I performed a search on JIRA and did not find anything related to this item; therefore
I am creating this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message