struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maurizio Cucchiara (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-2856) Client Side Javascript doesn't get generated when using Guice for dependency injection
Date Wed, 11 Jan 2012 02:37:39 GMT

    [ https://issues.apache.org/jira/browse/WW-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183816#comment-13183816
] 

Maurizio Cucchiara commented on WW-2856:
----------------------------------------

{quote}
As you've implied, maybe this should be filed against Guice, not Struts2
{quote}
Exactly.
{quote}
but, if Struts2 allows for replacement of the DI implementation, one could argue that said
replacement should not break Struts2
{quote}
Not in this case:
Struts [makes some checks/assignments|http://goo.gl/CIHj2] (see the snippet above) against
the interceptor stack which can't work using Guice, since it wraps the interceptor stack with
a private class called [ProvidedInterceptor|http://goo.gl/cY4z7]
{code}
List<InterceptorMapping> interceptors = actionConfig.getInterceptors();
for (InterceptorMapping interceptorMapping : interceptors) {
    // this condition will never be true 
    if (ValidationInterceptor.class.isInstance(interceptorMapping.getInterceptor())) {
        // this cast would never be possible
        ValidationInterceptor validationInterceptor = (ValidationInterceptor) interceptorMapping.getInterceptor();
        ...
            addParameter("performValidation", Boolean.TRUE);
        ...
        return;
    }
}
{code}
So the only advise I can give you is to file an issue on the [Guice project tracker|http://goo.gl/VTlmF]
                
> Client Side Javascript doesn't get generated when using Guice for dependency injection
> --------------------------------------------------------------------------------------
>
>                 Key: WW-2856
>                 URL: https://issues.apache.org/jira/browse/WW-2856
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 2.1.2
>         Environment: Windows Vista, Sun JDK 6, Tomcat 6.  struts2-guice-plugin v 1.0.1
and snapshot 20081016.
>            Reporter: Adam Ruggles
>             Fix For: 2.5
>
>
> See http://goo.gl/vbBiy for more details.
> Client Side Javascript doesn't get generated when using the struts2-guice-plugin.  performValidation
is never set to true when using the guice plugin.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message