struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lukasz Lenart (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3758) Please update commons-lang dep. to version 3.1
Date Tue, 21 Feb 2012 14:12:35 GMT

    [ https://issues.apache.org/jira/browse/WW-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212602#comment-13212602
] 

Lukasz Lenart commented on WW-3758:
-----------------------------------

This change affects 88 files, poms and Java classes. The main reasons is that the package
changed and few escape methods.
I've implemented the change and all the tests passed, instead using escapeHtml, I've switched
to escapeHtml4.

Looks ok, but I would like to hear your opinion.
                
> Please update commons-lang dep. to version 3.1
> ----------------------------------------------
>
>                 Key: WW-3758
>                 URL: https://issues.apache.org/jira/browse/WW-3758
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Tags
>    Affects Versions: 2.3.1.2
>         Environment: JRE/JDK 1.6.30, Tomcat 7.0
>            Reporter: Muslimov Maxim
>            Priority: Minor
>              Labels: StringEscapeUtils,, commons-lang,, dependencies
>             Fix For: 2.3.2
>
>
> Struts depends on old version of commons-lang package (2.5).
> This package contains class StringEscapeUtils, which contains escapeHtml method.
> This method escapes cyrillic symbols too. 
> (In new version commons-lang, which contains escapeHtml3 and escapeHtml4 methods cyrillic
not escapes)
> So if I use tags like <s:property value="foo" escapeHtml="true"/> I get html-content
with escaped sequence of char like &8231;&1233;&1234 and so on.
> It's makes response body too large for russian-languaged sites.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message