struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (WW-3753) The AnnotationActionValidatorManager does not adhere to the ActionValidatorManager interface's contract
Date Sun, 26 Feb 2012 09:40:48 GMT

    [ https://issues.apache.org/jira/browse/WW-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216685#comment-13216685
] 

Hudson commented on WW-3753:
----------------------------

Integrated in Struts2 #421 (See [https://builds.apache.org/job/Struts2/421/])
    WW-3753 -  adheres AnnotationActionValidatorManager to  ActionValidatorManager interface's
contract (Revision 1293791)

     Result = UNSTABLE
lukaszlenart : 
Files : 
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java
* /struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/ValidationInterceptor.java
* /struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManagerTest.java

                
> The AnnotationActionValidatorManager does not adhere to the ActionValidatorManager interface's
contract
> -------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3753
>                 URL: https://issues.apache.org/jira/browse/WW-3753
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: Rees Byars
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.2
>
>         Attachments: ww3753_patch
>
>
> An ActionValidatorManager accepts a java.util.String "context" parameter for identifying
the appropriate configurations.  In the AnnotationActionValidatorManager's buildValidatorKey()
method, however, "config.getName()" is used instead of the passed-in context.  This violates
the contract of the interface and tightly couples the AnnotationActionValidatorManager to
the ValidationInterceptor.  
> I have a situation whereby I have created my own validation interceptor for a special
case that passes in a context not derived from "proxy.getActionName()" (equivalent to config.getName()
except for in the case of wildcards), only to find that this context isn't used properly by
the manager.  I then created my own manager, changing only the buildValidatorKey() to use
the given context, and it works well. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message