struts-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lorenzo Bernacchioni (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (WW-3852) CLONE - FileUploadInterceptor and TokenInterceptor should use the configured custom TextProvider
Date Tue, 17 Jul 2012 14:11:35 GMT

     [ https://issues.apache.org/jira/browse/WW-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Lorenzo Bernacchioni updated WW-3852:
-------------------------------------

    Description: 
Struts2 supports the usage of a custom text provider by setting some environment constants
in struts.xml:

example:
<bean class="test.CustomTextProvider" name="myTextProvider" type="com.opensymphony.xwork2.TextProvider"
/> 
<constant name="struts.xworkTextProvider" value="myTextProvider" />

The struts2 core FileUploadInterceptor and the TokenInterceptor don't use this new custom
TextProvider hence they use  XWork's LocalizedTextUtil class to lookup translations. Why the
translations don't get resolved via an injected TextProvider?


At least method:
private String getTextMessage(Object action, String messageKey, Object[] args, Locale locale)
{
should have a "protected" signature to allow override.

More comments in the WW-3552 Clone.

  was:
Struts2 supports the usage of a custom text provider by setting some environment constants
in struts.xml:

example:
<bean class="test.CustomTextProvider" name="myTextProvider" type="com.opensymphony.xwork2.TextProvider"
/> 
<constant name="struts.xworkTextProvider" value="myTextProvider" />

The struts2 core FileUploadInterceptor and the TokenInterceptor don't use this new custom
TextProvider hence they use  XWork's LocalizedTextUtil class to lookup translations. Why the
translations don't get resolved via an injected TextProvider?

More comments in the WW-3552 Clone.

    
> CLONE - FileUploadInterceptor and TokenInterceptor should use the configured custom TextProvider
> ------------------------------------------------------------------------------------------------
>
>                 Key: WW-3852
>                 URL: https://issues.apache.org/jira/browse/WW-3852
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Interceptors
>    Affects Versions: 2.3.4
>            Reporter: Lorenzo Bernacchioni
>            Assignee: Maurizio Cucchiara
>              Labels: i18n, interceptors
>             Fix For: 2.3.4
>
>
> Struts2 supports the usage of a custom text provider by setting some environment constants
in struts.xml:
> example:
> <bean class="test.CustomTextProvider" name="myTextProvider" type="com.opensymphony.xwork2.TextProvider"
/> 
> <constant name="struts.xworkTextProvider" value="myTextProvider" />
> The struts2 core FileUploadInterceptor and the TokenInterceptor don't use this new custom
TextProvider hence they use  XWork's LocalizedTextUtil class to lookup translations. Why the
translations don't get resolved via an injected TextProvider?
> At least method:
> private String getTextMessage(Object action, String messageKey, Object[] args, Locale
locale) {
> should have a "protected" signature to allow override.
> More comments in the WW-3552 Clone.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message